Improve macOS dictation and IME marked-text overlays#561
Open
SilverMarcs wants to merge 3 commits into
Open
Conversation
Account for NSTextField internal cell margins when measuring text bounds so the overlay height correctly reflects word-wrapping. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Owner
|
This looks fabulous, how can I test this and take it for a spin? |
Contributor
Author
You can just trigger the system wide dictation (f5 key) on Mac keyboards) and on a less wide window, the preview should overflow a lot better |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements wrapped and exclusion-path bounded NSTextView rendering for dictation overlays (DictationOverlayTextView). This wraps long marked text input and paints background fills precisely under active text fragments per line-fragment to avoid clipping or overlapping prompt elements.