Skip to content
This repository has been archived by the owner on Aug 25, 2021. It is now read-only.

Refactor 20190625 #299

Open
wants to merge 2 commits into
base: 2.x
Choose a base branch
from
Open

Refactor 20190625 #299

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f792e9
chore: remove dead code
noscripter Jun 26, 2019
ba7a480
refactor: fix Ineffective parameter type
noscripter Jun 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/component-auto-patching/src/patchers/HttpClientPatcher.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ export class HttpClientPatcher extends Patcher {
} else if (url && url instanceof URL) {
_url = urlToOptions(url);
} else {
_options = url;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's not dead code

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable _options with null and undefined have the same effect for the following statement, so it's better to be removed. Just my 2 cents, up to your judgement.

_url = null;
}

Expand Down
2 changes: 1 addition & 1 deletion packages/hub/src/domain.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ export interface LookupPackage extends MessagePackage {
}

export interface ForceReplyFn {
(ReplyPackage): void;
(reply: ReplyPackage): void;
}

export interface SelectedInfo {
Expand Down