Skip to content

chore: document DCO sign-off requirement in CONTRIBUTING.md#1312

Open
KrisF-Midnight wants to merge 6 commits intomainfrom
chore/dco-contributing-md
Open

chore: document DCO sign-off requirement in CONTRIBUTING.md#1312
KrisF-Midnight wants to merge 6 commits intomainfrom
chore/dco-contributing-md

Conversation

@KrisF-Midnight
Copy link
Copy Markdown
Contributor

Overview

The organization-wide DCO migration is underway (replacing CLA Assistant). The DCO GitHub App is now installed on this repo and every PR is checked against it, but CONTRIBUTING.md does not yet tell contributors how to comply. This PR documents the sign-off requirement.

Changes:

  • Adds a Developer Certificate of Origin (DCO) section to CONTRIBUTING.md explaining git commit -s, amending prior commits with git rebase --signoff HEAD~N, and links to https://developercertificate.org/.
  • Notes that the DCO GitHub App will block PRs without sign-off.
  • Updates the commit-messages bullet to mention git commit -s.
  • Adds a DCO sign-off checkbox to .github/pull_request_template.md.

Wording mirrors midnightntwrk/compact-tree-sitter#35 for consistency across repos.

🗹 TODO before merging

  • Ready

📌 Submission Checklist

  • All commits are signed off (git commit -s) for the DCO
  • Changes are backward-compatible (or flagged if breaking)
  • Pull request description explains why the change is needed
  • Self-reviewed the diff
  • I have included a change file, or skipped for this reason: docs-only change, does not affect node/toolkit/runtime images
  • If the changes introduce a new feature, I have bumped the node minor version
  • Update documentation (if relevant)
  • Updated AGENTS.md if build commands, architecture, or workflows changed
  • No new todos introduced

🧪 Testing Evidence

Docs-only change. Rendered Markdown inspected locally.

  • Additional tests are provided (if possible)

🔱 Fork Strategy

  • Node Runtime Update
  • Node Client Update
  • Other:
  • N/A

Links

Adds a Developer Certificate of Origin (DCO) section to CONTRIBUTING.md
explaining the sign-off requirement, how to sign off with git commit -s,
and how to retroactively sign off prior commits. Also adds a DCO
sign-off checkbox to the PR template.

The DCO GitHub App is now installed on the repo and will block PRs
whose commits are missing Signed-off-by trailers.

Signed-off-by: Krisztian Feher <krisztian.feher@iohk.io>
KrisF-Midnight and others added 3 commits April 13, 2026 13:49
Contributors can install a local .git/hooks/prepare-commit-msg hook so
that every commit in this repo is signed off automatically, without
needing to remember the -s flag each time.

Signed-off-by: Krisztian Feher <krisztian.feher@iohk.io>
Comment thread CONTRIBUTING.md

A DCO GitHub App runs on every pull request and will block merges until all commits are signed off.

### Automating sign-off
Copy link
Copy Markdown
Contributor

@ozgb ozgb Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add some exception here - if you automate sign-off, code-assistant tools (e.g. Claude, Codex) should be disallowed from creating commits

A human needs to sign the commit: https://github.com/torvalds/linux/blob/master/Documentation/process/coding-assistants.rst#signed-off-by-and-developer-certificate-of-origin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants