Skip to content

fix LongArrayTag #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Lirsty wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix LongArrayTag #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
440abff
fix LongArrayTag
Lirsty Aug 9, 2020
6fef39d
Update go.mod
rainchi Aug 10, 2020
7fbde95
Merge pull request #1 from rain931215/patch-1
Lirsty Aug 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
module github.com/midnightfreddie/nbt2json
module github.com/Lirsty/nbt2json

go 1.13

Expand Down
2 changes: 1 addition & 1 deletion json2nbt.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ func writePayload(w io.Writer, m map[string]interface{}, tagType float64) error
}
case 12:
if values, ok := m["value"].([]interface{}); ok {
err = binary.Write(w, byteOrder, int64(len(values)))
err = binary.Write(w, byteOrder, int32(len(values)))
if err != nil {
return JsonParseError{"Error writing int64 array length", err}
}
Expand Down
9 changes: 5 additions & 4 deletions nbt2json.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,18 +268,19 @@ func getPayload(r *bytes.Reader, tagType byte) (interface{}, error) {
case 12:
var longArray []NbtLong
var longStringArray []string
var numRecords, oneInt int64
var numRecords int32
var oneInt int64
err := binary.Read(r, byteOrder, &numRecords)
if err != nil {
return nil, NbtParseError{"Reading long array tag length", err}
}
for i := int64(1); i <= numRecords; i++ {
for i := int32(1); i <= numRecords; i++ {
err := binary.Read(r, byteOrder, &oneInt)
if err != nil {
return nil, NbtParseError{"Reading long in long array tag", err}
}
longArray = append(longArray, longToIntPair(i))
longStringArray = append(longStringArray, fmt.Sprintf("%d", i))
longArray = append(longArray, longToIntPair(oneInt))
longStringArray = append(longStringArray, fmt.Sprintf("%d", oneInt))
}
if longAsString {
output = longStringArray
Expand Down