Fix voice bridge test service setup - #328115
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: db94f3da-b5b5-4265-b2f6-f4dd41a4527c
Contributor
There was a problem hiding this comment.
🟢 Ready to approve
The mocks satisfy the constructor contract and follow existing test patterns.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
Updates the voice bridge tests to match NewChatVoiceTargetService’s constructor.
Changes:
- Adds mocked session and chat widget services.
- Reuses a helper to construct test targets.
File summaries
| File | Description |
|---|---|
src/vs/sessions/contrib/chat/test/browser/voiceBridge.test.ts |
Supplies required mocked dependencies. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Medium
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
meganrogge
enabled auto-merge (squash)
July 29, 2026 22:01
vritant24
approved these changes
Jul 29, 2026
auto-merge was automatically disabled
July 29, 2026 22:10
Pull request was closed
meganrogge
enabled auto-merge (squash)
July 29, 2026 22:11
connor4312
disabled auto-merge
July 29, 2026 22:22
connor4312
enabled auto-merge
July 29, 2026 22:22
roblourens
added a commit
that referenced
this pull request
Jul 29, 2026
Resolve the voice bridge test conflict by taking the upstream service-mock fix from #328115.\n\n(Written by Copilot)\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
voiceBridge.test.tsto constructNewChatVoiceTargetServicewith mockedISessionsServiceandIChatWidgetServicedependencies.This fixes the core CI TypeScript errors introduced when the service constructor gained two required arguments.