Collapse ., / ,, punctuation artifacts in dictation transcript cleanup

[Copilot]

Description

Dictated text landed in the chat input with artifacts like things., first and any,, meaningful, even though the LLM cleanup requests themselves returned well-formatted text.

Root cause: incremental cleanup produces a formatted cleaned prefix that is then concatenated with the still-raw transcript tail. When the prefix ended in a sentence terminator and the tail began with a separator (things. + , first), or raw commas doubled up, stripDictationFillers — the final normalization applied to both the live display and the returned transcript — collapsed spaces before punctuation but never collapsed the adjacent-punctuation runs themselves. So the artifacts survived into the final input.

Changes:

• stripDictationFillers — collapse redundant punctuation runs, keeping the stronger sentence terminator and dropping redundant separators. Only runs involving a ,/; separator are touched, so ... ellipses and ?! are preserved.

  .replace(/[,;]+[ \t]*([.!?])/g, '$1')   // ", ." / ",." -> "."
  .replace(/([.!?])[ \t]*[,;]+/g, '$1')   // ".,"        -> "."
  .replace(/([,;])[ \t]*[,;]+/g, '$1')    // ",,"        -> ","

  Since this is the single final pass for the final transcript, the live display, and the raw fallback when LLM cleanup is skipped or fails faithfulness, the fix applies uniformly.

• Exported stripDictationFillers and added a unit test covering the reported cases.

Scope note: the earlier hypothesis of racing async writers is already guarded by beginFinalize() + _resetIncrementalCleanup(); the artifacts originated from concatenation/normalization, so the change is kept to the cleanup pass rather than reworking writer coordination.

• Fixes #https://github.com/microsoft/vscode-internalbacklog#8611

[Copilot]

Pull request overview

Normalizes punctuation artifacts created when cleaned dictation prefixes are joined with raw transcript tails.

Changes:

• Collapses redundant comma/semicolon punctuation runs.
• Adds unit coverage for reported transcript artifacts.

Show a summary per file

File	Description
chatSpeechToTextService.ts	Adds punctuation normalization to dictation cleanup.
chatSpeechToTextService.test.ts	Tests representative punctuation artifacts.

Review details

• Files reviewed: 2/2 changed files
• Comments generated: 0
• Review effort level: Medium

[github-actions]

Screenshot Changes

Base: b7c14909 Current: 8b7f3131

Changed (6)

agentsVoice/voiceModeOnboarding/Voice Mode onboarding (panel)/Dark

Before	After

agentsVoice/voiceModeOnboarding/Voice Mode onboarding (panel)/Light

Before	After

agentsVoice/voiceModeOnboarding/Voice Mode onboarding (wide)/Dark

Before	After

agentsVoice/voiceModeOnboarding/Voice Mode onboarding (wide)/Light

Before	After

agentsVoice/voiceModeOnboarding/Voice Mode onboarding (narrow)/Dark

Before	After

agentsVoice/voiceModeOnboarding/Voice Mode onboarding (narrow)/Light

Before	After