fix(markdown): prevent angle brackets from auto-closing inside math blocks#325464
Open
singhlovepreet9 wants to merge 1 commit into
Open
fix(markdown): prevent angle brackets from auto-closing inside math blocks#325464singhlovepreet9 wants to merge 1 commit into
singhlovepreet9 wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Prevents angle brackets from auto-closing inside Markdown math regions.
Changes:
- Classifies Markdown math scopes as string tokens.
- Includes an unrelated extension enablement action change that should be removed or split out.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
extensions/markdown-math/package.json |
Marks math scopes as string tokens. |
src/vs/workbench/contrib/extensions/browser/extensionsActions.ts |
Alters global-disable action availability. |
| } | ||
| this.enabled = this.extension.state === ExtensionState.Installed | ||
| && (this.extension.enablementState === EnablementState.EnabledGlobally || this.extension.enablementState === EnablementState.EnabledWorkspace) | ||
| && (this.extension.enablementState === EnablementState.EnabledGlobally || (this.extension.enablementState === EnablementState.EnabledWorkspace && !this.extensionEnablementService.isDisabledGlobally(this.extension.local))) |
Author
@microsoft-github-policy-service agree |
singhlovepreet9
force-pushed
the
fix-markdown-math-autoclose
branch
from
a6f1c09 to
20489d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #272922
When typing
<inside markdown math blocks ($ ... $), it currently auto-closes to<>because the markdown language configuration specifies that angle brackets should auto-close unless inside astring.This PR assigns the
meta.embedded.math.markdownscope to thestringtoken type inextensions/markdown-math/package.json. This elegantly prevents the unwanted auto-closing of<inside LaTeX math blocks without requiring any renaming of textmate scopes.