Skip to content

local → agent host migration: In‑place switch, imported session fidelity#325458

Merged
vijayupadya merged 3 commits into
mainfrom
vijayu/ah-migration-updates
Jul 12, 2026
Merged

local → agent host migration: In‑place switch, imported session fidelity#325458
vijayupadya merged 3 commits into
mainfrom
vijayu/ah-migration-updates

Conversation

@vijayupadya

@vijayupadya vijayupadya commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

Description

Improves the experience of continuing a local chat in an agent‑host session (Copilot CLI), so it feels like the same conversation continuing rather than jumping into a brand‑new, different-looking session.

What changed

In‑place switch (no jarring navigation)

  • Editor path: replace the source chat editor in place instead of opening a new tab (replaceEditor: !isSidebar); falls back to opening a new editor if there's no active chat editor, so a pending send is never lost.
  • Sidebar path: suppress the chat Sessions list for the whole migration transition (load → materializing send → untitled→real rebind), so it no longer flashes the session list mid‑switch.
  • Show the chat view's working indicator for the duration of that transition so the (unavoidable) backend‑materialization gap doesn't look hung.

Imported session reads like a normal session

  • Generate a title from the imported conversation (reusing the existing fork‑title path), so migrated sessions get clean titles like any other.
  • Imported inline file/symbol references now show short labels (file basename / symbol name) instead of leaking full workspace‑relative paths.

Copilot AI review requested due to automatic review settings July 12, 2026 04:04
@vijayupadya vijayupadya changed the title local → agent host "Continue in" migration - in‑place switch, imported session fidelity local → agent host migration - in‑place switch, imported session fidelity Jul 12, 2026
@vijayupadya vijayupadya changed the title local → agent host migration - in‑place switch, imported session fidelity local → agent host migration: In‑place switch, imported session fidelity Jul 12, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Improves local-chat migration into Agent Host sessions while preserving conversation fidelity and reducing disruptive UI transitions.

Changes:

  • Replaces source chat editors in place and suppresses transient sidebar UI.
  • Adds preparation progress and generated imported-session titles.
  • Shortens imported file and symbol reference labels.
Show a summary per file
File Description
chatContinueInAction.ts Requests in-place editor migration.
chatSessions.contribution.ts Manages replacement, suppression, and progress.
chatViewPane.ts Adds session-list suppression support.
agentHostSessionHandler.ts Shows delayed preparation status.
agentService.ts Generates imported-session titles.
importLocalConversationToAgentSession.ts Shortens imported reference labels.
importLocalConversationToAgentSession.test.ts Tests reference-label conversion.

Review details

  • Files reviewed: 7/7 changed files
  • Comments generated: 4
  • Review effort level: Medium

Comment thread src/vs/workbench/contrib/chat/browser/chatSessions/chatSessions.contribution.ts Outdated
Comment thread src/vs/platform/agentHost/node/agentService.ts Outdated
@vijayupadya vijayupadya marked this pull request as ready for review July 12, 2026 06:14
@vijayupadya vijayupadya enabled auto-merge (squash) July 12, 2026 06:14
@vijayupadya vijayupadya merged commit 1adedfc into main Jul 12, 2026
61 of 65 checks passed
@vijayupadya vijayupadya deleted the vijayu/ah-migration-updates branch July 12, 2026 15:28
@vs-code-engineering vs-code-engineering Bot added this to the 1.129.0 milestone Jul 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants