fix: improve user prompt handling by ignoring non-text content and adding fallback options#324426
Merged
Conversation
…ding fallback options
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a Copilot CLI Agent failure where generateUserPrompt would throw when the rendered prompt included non-text parts (e.g. image content), by extracting only text parts and providing safe fallback behavior so agent sessions don’t abort (Issue #323696).
Changes:
- Update
generateUserPromptto ignore non-text content and return concatenated text from rendered user messages. - Add fallback behavior to use the override prompt or original
request.promptwhen rendered user text is empty. - Expand unit tests to cover mixed content and fallback scenarios.
Show a summary per file
| File | Description |
|---|---|
| extensions/copilot/src/extension/prompts/node/agent/test/copilotCLIPrompt.spec.ts | Updates tests to validate ignoring non-text content and exercising fallback prompt behavior. |
| extensions/copilot/src/extension/prompts/node/agent/copilotCLIPrompt.tsx | Adjusts prompt extraction logic to ignore non-text parts and avoid throwing on unexpected prompt structures. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 3
- Review effort level: Low
Yoyokrazy
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #323696