Add smoke tests for model configs#323205
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds a new end-to-end smoke test suite that validates chat model configuration selections (reasoning effort + context size) are forwarded to the LLM request payload, using the existing mock LLM server infrastructure and new automation helpers for interacting with the chat model picker UI.
Changes:
- Register and run a new “Chat Model Configuration” smoke suite in the Electron (non-remote) smoke test run.
- Add chat automation helpers to select a model and its configuration options via the model picker UI.
- Extend the mock LLM server to expose captured request bodies for assertions, and add a dedicated mock model that supports both reasoning effort and a long-context tier.
Show a summary per file
| File | Description |
|---|---|
| test/smoke/src/main.ts | Wires the new chat model configuration smoke suite into the Electron smoke run. |
| test/smoke/src/areas/chat/chatModelConfig.test.ts | New smoke suite that drives the model picker UI and asserts forwarded reasoning.effort and context-management threshold in /responses. |
| test/automation/src/chat.ts | Adds automation methods for selecting a chat model and interacting with the model configuration dropdown. |
| scripts/chat-simulation/common/mock-llm-server.ts | Adds a mock model with config pickers and exposes captured request bodies via getRequests(). |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 2
- Review effort level: Low
…icky click Clicking the context-usage gauge opens its details popup as a *sticky* hover (persistence.sticky => HoverWidget.isLocked=true): focus-trapping and not closable by Escape. The locked overlay then sits over the model-config button, so the next openModelConfig force-click lands on the popup and the dropdown never opens. Read the label via the gauge's delayed (non-sticky) hover instead, triggered by a raw pointer move to the gauge's center (boundingBox + page.mouse.move) rather than locator.hover(): the gauge expands on hover and its progress arc animates, so hover()'s actionability/stability check can hang for the full timeout. Moving the pointer away first guarantees a fresh mouse-enter on each retry; the non-sticky hover auto-hides when the pointer parks back at (0,0). Applied to chat.ts and agentsWindow.ts.
roblourens
approved these changes
Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flake busting #323242