Fixes hidden css stylesheet order dependency#322619
Open
hediet wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses hidden CSS override fragility caused by stylesheet concatenation order by increasing selector specificity so intended overrides win deterministically.
Changes:
- Increase specificity of the chat agent feedback review confirmation padding override so it wins over the generic confirmation widget padding rule regardless of CSS ordering.
- Increase specificity of
.sidebar-action-buttonstyling in the Agents window so it reliably overrides base.monaco-text-buttonrules.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/widget/chatContentParts/media/chatAgentFeedbackReviewConfirmation.css | Raises specificity of the feedback review list padding override to avoid order-dependent behavior. |
| src/vs/sessions/browser/media/sidebarActionButton.css | Raises specificity of sidebar action button styling to avoid order-dependent overrides vs base button styles. |
Copilot's findings
- Files reviewed: 2/3 changed files
- Comments generated: 1
Comment on lines
+131
to
139
| /* The extra :not(:has(.chat-confirmation-message-terminal)) qualifier is a no-op | ||
| * here (a feedback review list never contains a terminal) but raises this rule's | ||
| * specificity above the generic | ||
| * `.chat-confirmation-widget2 .chat-confirmation-widget-message:not(:has(.chat-confirmation-message-terminal))` | ||
| * padding rule in chatConfirmationWidget.css so this override wins regardless of | ||
| * stylesheet concatenation order. */ | ||
| .chat-confirmation-widget2 .chat-confirmation-widget-message:has(.chat-agent-feedback-review-list):not(:has(.chat-confirmation-message-terminal)) { | ||
| padding: var(--vscode-spacing-size60) var(--vscode-spacing-size120) var(--vscode-spacing-size60) var(--vscode-spacing-size60); | ||
| } |
sandy081
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.