AH: fix client side tools not getting auto approved#322593
Open
justschen wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes client-contributed tool calls (e.g. Playwright) still showing approval prompts when the session is in Bypass Approvals mode by stamping autoApproveBySetting onto the initial chat/toolCallStart action so the workbench can auto-approve client-side confirmations.
Changes:
- Stamp
autoApproveBySetting: trueinto_metafor client-contributedChatToolCallStartactions whenautoApprove === 'autoApprove'. - Apply the stamping consistently in both the “no active turn” and “active turn” action dispatch paths.
- Add unit tests covering client vs non-client tool starts under bypass vs default approval settings.
Show a summary per file
| File | Description |
|---|---|
src/vs/platform/agentHost/node/agentSideEffects.ts |
Adds _stampClientToolAutoApprove and routes dispatched actions through it to propagate bypass-approval intent for client tools. |
src/vs/platform/agentHost/test/node/agentSideEffects.test.ts |
Adds regression tests ensuring autoApproveBySetting is stamped only for client tool starts under bypass approvals. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #322557