Skip to content

AH: fix client side tools not getting auto approved#322593

Open
justschen wants to merge 1 commit into
mainfrom
justin/solgaleo
Open

AH: fix client side tools not getting auto approved#322593
justschen wants to merge 1 commit into
mainfrom
justin/solgaleo

Conversation

@justschen

Copy link
Copy Markdown
Collaborator

fix #322557

Copilot AI review requested due to automatic review settings June 23, 2026 18:00
@justschen justschen changed the title fix client side tools not getting auto approved AH: fix client side tools not getting auto approved Jun 23, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes client-contributed tool calls (e.g. Playwright) still showing approval prompts when the session is in Bypass Approvals mode by stamping autoApproveBySetting onto the initial chat/toolCallStart action so the workbench can auto-approve client-side confirmations.

Changes:

  • Stamp autoApproveBySetting: true into _meta for client-contributed ChatToolCallStart actions when autoApprove === 'autoApprove'.
  • Apply the stamping consistently in both the “no active turn” and “active turn” action dispatch paths.
  • Add unit tests covering client vs non-client tool starts under bypass vs default approval settings.
Show a summary per file
File Description
src/vs/platform/agentHost/node/agentSideEffects.ts Adds _stampClientToolAutoApprove and routes dispatched actions through it to propagate bypass-approval intent for client tools.
src/vs/platform/agentHost/test/node/agentSideEffects.test.ts Adds regression tests ensuring autoApproveBySetting is stamped only for client tool starts under bypass approvals.

Copilot's findings

  • Files reviewed: 2/2 changed files
  • Comments generated: 0

@justschen justschen marked this pull request as ready for review June 23, 2026 18:05
@justschen justschen requested a review from connor4312 June 23, 2026 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AHP: Playwright tool approval even when I am in Bypass Approvals mode

2 participants