Allow wider SCM diff gutter decorations#321537
Open
FuZoe wants to merge 5 commits into
Open
Conversation
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @lszomoruMatched files:
|
Author
|
This PR is ready for review. Happy to address any feedback. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #278083
Why
scm.diffDecorationsGutterWidthwas limited to the enumerated values1through5, and the quick diff decorator also rejected values greater than5at runtime. That made the settings editor unable to pick wider gutter decorations, and manually entered larger values were reset to the default.What
1-5enum with a numeric range of1-20forscm.diffDecorationsGutterWidth.20are honored instead of falling back to3.Impact
This preserves the existing default of
3and keeps invalid values guarded, while allowing users to select wider Source Control diff gutter decorations when they need more visible indicators.Validation
npm run compile-check-ts-native -- --pretty false