Allow disabling AuthenticationProvider extension for workspace if not used by Settings Sync#320415
Open
gjsjohnmurray wants to merge 6 commits into
Open
Allow disabling AuthenticationProvider extension for workspace if not used by Settings Sync#320415gjsjohnmurray wants to merge 6 commits into
gjsjohnmurray wants to merge 6 commits into
Conversation
… used by Settings Sync
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adjusts extension enablement validation and messaging so Settings Sync dependency on an authentication provider extension is handled more precisely (including in workspace scope).
Changes:
- Fixes/clarifies the error message when Settings Sync depends on an authentication provider extension.
- Narrows the “cannot change enablement in workspace” restriction to only block the auth provider extension currently used by Settings Sync.
gjsjohnmurray
commented
Jun 8, 2026
gjsjohnmurray
left a comment
gjsjohnmurray
left a comment
Contributor
Author
There was a problem hiding this comment.
/assign @sandy081
Contributor
Author
|
@sandy081 please consider adding this to the 1.126 milestone. |
Member
|
Thanks @gjsjohnmurray! Since the 1.126 endgame is already underway, I've added this to 1.127.0 so it gets proper review and bake time rather than rushing it in late. Appreciate the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #269367