Skip to content

Fix forwarded ports status bar item to toggle the ports view #320090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexr00 merged 5 commits into from
Jul 27, 2026
+26 −2
Merged

Fix forwarded ports status bar item to toggle the ports view #320090

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
23751b3
Fix forwarded ports status bar item to toggle the ports view
thernstig Jun 5, 2026
bfb1048
Update forwarded ports toggle label for clarity
thernstig Jun 5, 2026
04ba058
Refactor forwarded ports toggle to use localized label and constants
thernstig Jun 9, 2026
417dece
Merge branch 'main' into toggle-forwarded-ports
alexr00 Jun 30, 2026
e304b94
Attestation commit
alexr00 Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion src/vs/workbench/contrib/remote/browser/remote.contribution.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,38 @@
* Licensed under the MIT License. See License.txt in the project root for license information.
*--------------------------------------------------------------------------------------------*/

import { localize } from '../../../../nls.js';
import { Action2, registerAction2 } from '../../../../platform/actions/common/actions.js';
import { IWorkbenchContributionsRegistry, WorkbenchPhase, Extensions as WorkbenchExtensions, registerWorkbenchContribution2 } from '../../../common/contributions.js';
import { Registry } from '../../../../platform/registry/common/platform.js';
import { ShowCandidateContribution } from './showCandidate.js';
import { LifecyclePhase } from '../../../services/lifecycle/common/lifecycle.js';
import { TunnelFactoryContribution } from './tunnelFactory.js';
import { RemoteAgentConnectionStatusListener, RemoteMarkers } from './remote.js';
import { RemoteStatusIndicator } from './remoteIndicator.js';
import { AutomaticPortForwarding, ForwardedPortsView, PortRestore } from './remoteExplorer.js';
import { AutomaticPortForwarding, ForwardedPortsView, PortRestore, TOGGLE_VIEW_ACTION_ID } from './remoteExplorer.js';
import { InitialRemoteConnectionHealthContribution } from './remoteConnectionHealth.js';
import { IViewsService } from '../../../services/views/common/viewsService.js';
import { TUNNEL_VIEW_ID } from '../../../services/remote/common/remoteExplorerService.js';
import { ServicesAccessor } from '../../../../platform/instantiation/common/instantiation.js';

registerAction2(class extends Action2 {
constructor() {
super({
id: TOGGLE_VIEW_ACTION_ID,
title: localize('remote.togglePortsView', "Toggle Forwarded Ports View"),
});
}

async run(accessor: ServicesAccessor): Promise<void> {
const viewsService = accessor.get(IViewsService);
if (viewsService.isViewVisible(TUNNEL_VIEW_ID)) {
viewsService.closeView(TUNNEL_VIEW_ID);
} else {
await viewsService.openView(TUNNEL_VIEW_ID, true);
}
}
Comment thread
thernstig marked this conversation as resolved.
});

const workbenchContributionsRegistry = Registry.as<IWorkbenchContributionsRegistry>(WorkbenchExtensions.Workbench);
registerWorkbenchContribution2(ShowCandidateContribution.ID, ShowCandidateContribution, WorkbenchPhase.BlockRestore);
Expand Down
3 changes: 2 additions & 1 deletion src/vs/workbench/contrib/remote/browser/remoteExplorer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ import { IPreferencesService } from '../../../services/preferences/common/prefer
import { IStorageService, StorageScope } from '../../../../platform/storage/common/storage.js';

export const VIEWLET_ID = 'workbench.view.remote';
export const TOGGLE_VIEW_ACTION_ID = 'remoteExplorer.toggleForwardedPortsView';

export class ForwardedPortsView extends Disposable implements IWorkbenchContribution {
private readonly contextKeyListener = this._register(new MutableDisposable<IDisposable>());
Expand Down Expand Up @@ -166,7 +167,7 @@ export class ForwardedPortsView extends Disposable implements IWorkbenchContribu
text: `$(radio-tower) ${text}`,
ariaLabel: tooltip,
tooltip,
command: `${TUNNEL_VIEW_ID}.focus`
command: TOGGLE_VIEW_ACTION_ID
};
}
}
Expand Down
Loading