Added getAmountOfDiffs and getIndexOfCurrentlyRevealedDiff to the IDiffEditor
#241579
+33
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/monaco-editor#4836.
This PR implements two API's:
getAmountOfDiffs: A helper method to know the current amount of diffs rendered in the IDiffEditorgetIndexOfCurrentlyRevealedDiff: A helper method to get the index of the currently revealed diffI was wondering if the
getIndexOfCurrentlyRevealedDiffcould instead be calledgetCurrentlyRevealedDiffand return an object containing{ index: number, diff: DiffMapping }, but i'm not sure if you wantDiffMappingto be exposed.These methods would be really helpful for giving helpful information about the diffs. The
goToDiffandrevealFirstDiffare great for navigating diffs, but if you want to display some information about the diffs then it's not really possible with the current setup.