Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: let TokenSelector support multi-languages #241556

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Colibrow
Copy link

Related to #66729 #181360 #199569.
Recently, I encountered an issue when trying to add language-specific token colors using editor.semanticTokenColorCustomizations. As noted in VS Code's semantic highlighting guide, the current implementation only supports grouping tokens under a single language.

This patch extends support for multiple languages by allowing definitions like class:c,cpp,python, enabling semantic token customization across multiple languages.

@Colibrow
Copy link
Author

@microsoft-github-policy-service agree

@Colibrow Colibrow force-pushed the users/Colibrow/spr/semantic-token-multi-language branch from ba64f68 to a2870fc Compare February 22, 2025 06:32
@Colibrow
Copy link
Author

@aeschli Hi, Could you please take a look?

@aeschli
Copy link
Contributor

aeschli commented Feb 24, 2025

Isn't it already possible to do the same by repeating the same rule?

"variable.readonly:java": "#ff0011"
"variable.readonly:javascript": "#ff0011"

@aeschli aeschli added the info-needed Issue requires more information from poster label Feb 24, 2025
@Colibrow
Copy link
Author

Isn't it already possible to do the same by repeating the same rule?

"variable.readonly:java": "#ff0011"
"variable.readonly:javascript": "#ff0011"

Yes. I do it by this way currently. But as for a theme settings for some languages for example:

"variable.readonly:java": "#ff0011"
"variable.readonly:javascript": "#ff0011"
"variable.readonly:cpp": "#ff0011"
"variable.readonly:c": "#ff0011"

"variable.variable:java": "#ff0011"
"variable.variable:javascript": "#ff0011"
"variable.variable:cpp": "#ff0011"
"variable.variable:c": "#ff0011"
...

It looks a little redundant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info-needed Issue requires more information from poster
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants