editor: fix glyph margin links not working #224352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shows this notification if a prelaunch task has been running for more than 10 seconds:  Also does a little cleanup of some probably-leaking disposables in the task runner. Fixes #218267
The constructor was missing decorations, so _openingService was always undefined and links did not open. Fixes #214786 cc @aiday-mar
bhavyaus
approved these changes
Jul 31, 2024
|
Thanks for the fix! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The constructor was missing decorations, so _openingService was always undefined and links did not open.
Fixes #214786
cc @aiday-mar