Draft PR: Working on issue #211394 #223082
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arup Chauhan <[email protected]>
|
Hi @Tyriar , I have made this PR to work. I wanted to ask, in the original issue was reported on a Linux OS machine. What do you suggest? |
|
@Arup-Chauhan the fix for this will be entirely in the https://github.com/xtermjs/xterm.js repo, when it's done I'll update the |
|
You should be able to test and make the fix on any OS |
Thanks, I will get started on the work |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raising a draft PR to work on #211394