# Add partial accept kind to inline completion handle

[marrej]

1st part of the partial accept handler enrichment

This first proposal enables the metadata to be attached in the core to the partialAcceptHandler to return the Kind of partial acceptance that was triggered.

This allows for deeper understanding of user interactions, as well as filtering out specific triggers when doing post analysis (e.g. Suggest).

#195369

[hediet]

[eslint ] [16:52:03] /mnt/vss/_work/1/s/src/vs/workbench/api/common/extHostTypeConverters.ts: line 2406, col 4, Warning - Missing semicolon. (@typescript-eslint/semi)

[marrej]

[eslint ] [16:52:03] /mnt/vss/_work/1/s/src/vs/workbench/api/common/extHostTypeConverters.ts: line 2406, col 4, Warning - Missing semicolon. (@typescript-eslint/semi)

Sorry for the early ping, I tried to keep the PR in draftmode but you already got assigned. The issues should be resolved now :)

[marrej]

Reworked the API (original proposed changes), to allow easy onboarding of new users (wouldn't cause breakage when released with extensions).

[marrej]

Hey @bhavyaus , Is there any additional changes that you would like me to add to the PR?

Also if I may be so bold to ask, why did you add the PartialAcceptInfo directly to the proposed API. Is it because the proposed APIs can break current extension implementations and are experimental only?

[bhavyaus]

Hey @bhavyaus , Is there any additional changes that you would like me to add to the PR?

Apologies. I was performing endgame testing. Ignore my previous comment.

Hey @bhavyaus , Is there any additional changes that you would like me to add to the PR?

Also if I may be so bold to ask, why did you add the PartialAcceptInfo directly to the proposed API. Is it because the proposed APIs can break current extension implementations and are experimental only?

@justschen , could you please help take a look.