-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
InlineCompletion PartialAccept additional info #195369
Comments
Hi @hediet is that something that you plan to do in the comming weeks? Or should I grab it and try to propose a change via PR? |
Feel free to provide a PR, but I cannot guarantee you that it will get merged. |
That sounds good to me, thanks! |
Please extend the current! |
Going through what I think would be interesting to have in the additional metadata I settled on this:
The reason for that is, to be able to get a better visibility on what happened in the core without having to hack in addtional listeners for typing/cursor changes, directly from the partialAccepts. The data mentioned above would allow to easily reconstruct all edits that happened in a document, and allow for better post processing of the data. I decided to split this in to 2 PRs:
The 1st is being sent out right now, while the 2nd will be sent out after discussion, as there may be some points that we might want to clarify further. |
TLDR; Would it be possible to extend the
handlePartialAccept
with metadata field, allowing to attach additional info, such as origin?It would help understanding in the downstream completion metrics, where acceptances are comming from to better understand user behavior. The field could be later on extended with any additional information if neccessary, e.g. in the case of partial accept it might be helpful to report back also the length of the accepted token (not only the length of the full acceptance from start of insertion to cursor position ).
The text was updated successfully, but these errors were encountered: