feat: enable gpu async channel feature to improve startup #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will push the flags into VSCode by default from March milestone since it is too late in the current milestone. However, I would like to start testing with the flag in the perf bot. Here is the upstream CL https://chromium-review.googlesource.com/c/chromium/src/+/6094045 that enables it since 134, we should get it once we update to E35 |
deepak1556
commented
Feb 23, 2025
| @@ -138,7 +138,12 @@ async function launchDesktop(options: Options, perfFile: string, markers: string | |||
| EXTENSIONS_FOLDER, | |||
| '--disable-extensions', | |||
| '--disable-workspace-trust', | |||
| '--disable-features=CalculateNativeWinOcclusion', // disable penalty for occluded windows | |||
There was a problem hiding this comment.
bpasero
requested changes
Feb 23, 2025
|
Closing in favor of microsoft/vscode#241640 |
auto-merge was automatically disabled
February 23, 2025 19:54
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating microsoft/vscode#240767 I see that the renderer main thread is blocked around 1s in establishing the gpu channel. Upstream has finished evaluation of the gpu async channel and has enabled it by default since Chromium 134. Here is the before and after with the feature enabled,
CrRendererMainis the main thread of the renderer, with the feature enabled we now push the channel to a different thread and free up main thread for other tasks.Before:
[perf] code/willOpenNewWindow-code/willLoadWorkbenchMain: 1295ms (fastest), 1295ms (slowest), 1295ms (median)
After:
[perf] code/willOpenNewWindow-code/willLoadWorkbenchMain: 310ms (fastest), 310ms (slowest), 310ms (median)