Skip to content

add option to skip opening the generated extension #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aeschli merged 1 commit into from
Mar 17, 2025
Merged

add option to skip opening the generated extension #514

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions generators/app/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ export default class extends Generator {
this.option('quick', { type: Boolean, alias: 'q', description: 'Quick mode, skip all optional prompts and use defaults' });
this.option('open', { type: Boolean, alias: 'o', description: 'Open the generated extension in Visual Studio Code' });
this.option('openInInsiders', { type: Boolean, alias: 'O', description: 'Open the generated extension in Visual Studio Code Insiders' });

this.option('skipOpen', { type: Boolean, alias:'s', description: 'Skip opening the generated extension in Visual Studio Code' });
this.option('extensionType', { type: String, alias: 't', description: extensionGenerators.slice(0, 6).map(e => e.aliases[0]).join(', ') + '...' });
this.option('extensionDisplayName', { type: String, alias: 'n', description: 'Display name of the extension' });
this.option('extensionId', { type: String, description: 'Id of the extension' });
Expand Down Expand Up @@ -242,7 +242,7 @@ export default class extends Generator {

const [codeStableLocation, codeInsidersLocation] = await Promise.all([which('code').catch(() => undefined), which('code-insiders').catch(() => undefined)]);

if (!this.extensionConfig.insiders && !this.options['open'] && !this.options['openInInsiders'] && !this.options['quick']) {
if (!this.extensionConfig.insiders && !this.options['open'] && !this.options['openInInsiders'] && !this.options['quick'] && !this.options['skipOpen']) {
const cdLocation = this.options['destination'] || this.extensionConfig.name;

this.log('To start editing with Visual Studio Code, use the following commands:');
Expand All @@ -265,6 +265,10 @@ export default class extends Generator {
this.log('For more information, also visit http://code.visualstudio.com and follow us @code.');
this.log('\r\n');

if (this.options['skipOpen']) {
return;
}

if (this.options["open"]) {
if (codeStableLocation) {
this.log(`Opening ${this.destinationPath()} in Visual Studio Code...`);
Expand Down