-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Adding vcpkg to cpp image definitions #1310
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few questions/comments.
@Chuxel Changes made based on your feedback. Ready for another pass when you get a chance. |
Also, since you asked about it during the design review we wanted to just confirm for you that the base image size increases from 1.45GB to 1.50GB with this change. |
@Chuxel do we also need to update the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Chuxel do we also need to update the
definition-manifest
at all given the new package dependencies the install-vcpkg script adds on some base images (all but stretch and bionic)? I don't know enough about how that file gets used to determine on my own. Let me know what you think :)
@bderusha Yeah that would be a good idea for anything that ends up in the image. Packages installed from apt from the main distro are covered by registrying the distro (which is already done). 3rd party dependencies, however, should be added. cmake we can just use the version that is installed... worst case we register one we're already covered by.
Otherwise LGTM!!
@Chuxel Updated the definition-manifest. |
LGTM! Merging! |
#781
Description
This PR adds:
base.Dockerfile
to add support for Vcpkg c++ package managerDockerfile
to support conditional CMake re-install from an official releasePR Checklist
Does this introduce a breaking change?
Testing
test-project/test.sh
updated to ensure Vcpkg is configured and can runvcpkg --version
Other information or known dependencies