Add instrumentation support to the typescript code #12991
+2,683
−2,607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rosoft/vscode-cpptools into dev/garretts/instrumentation
bobbrow
reviewed
Dec 5, 2024
| } | ||
|
|
||
| export function getLoggingLevel() { | ||
| return getNumericLoggingLevel(vscode.workspace.getConfiguration("C_Cpp", null).get<string>("loggingLevel")); |
There was a problem hiding this comment.
Since we can't pull CppSettings into this module, maybe we need to split out the validation code because we shouldn't be reading raw settings in the extension anymore. Apparently this file was skipped due to it not using CppSettings.
This isn't necessarily your problem. I'm just thinking out loud.
…nto dev/garretts/instrumentation
…nto dev/garretts/instrumentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the instrumentation support to enable performance testing and monitoring.
It:
PERFECTO_LAUNCH_SETTINGSenvironment variable is not set, everything here is a no-op