Update prompt services to open text document instead of reading files #2265
+23
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
commented
Nov 28, 2025
| const documentText = this.workspaceService.textDocuments.find(doc => isEqual(doc.uri, fileUri))?.getText(); | ||
| let content = documentText ?? new TextDecoder().decode(await this.fileSystemService.readFile(fileUri)); | ||
| const doc = await this.workspaceService.openTextDocument(fileUri); | ||
| let content = doc.getText(); |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors prompt file reading operations to use VS Code's text document API (IWorkspaceService.openTextDocument()) instead of directly reading files with IFileSystemService.readFile(). This change provides better integration with VS Code's document management system, including caching and change tracking capabilities.
Key Changes
- Updated
PromptsServiceImplto useIWorkspaceServiceinstead ofIFileSystemServicefor reading prompt files - Improved cancellation handling using
raceCancellationError()utility - Updated
CopilotCLIChatSessionParticipantto use the newIPromptsServiceAPI and properly thread cancellation tokens through method calls
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/platform/promptFiles/common/promptsServiceImpl.ts | Replaced file system reading with workspace text document API and improved cancellation handling |
| src/platform/promptFiles/common/promptsService.ts | Added _serviceBrand property to interface for proper service typing |
| src/extension/prompts/node/panel/promptFile.tsx | Updated to use openTextDocument() instead of finding or reading documents directly, removed unused imports |
| src/extension/chatSessions/vscode-node/copilotCLIChatSessionsContribution.ts | Refactored to use IPromptsService for parsing prompt files and added cancellation token parameter to relevant methods |
| src/extension/chatSessions/vscode-node/test/copilotCLIChatSessionParticipant.spec.ts | Updated test to instantiate PromptsServiceImpl with required IWorkspaceService dependency |
jrieken
approved these changes
Nov 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.