[nghttp2] update to 1.65.0 #44120
Open
[nghttp2] update to 1.65.0 #44120
+8
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove cmake with ngtcp2 quictls flags
MonicaLiu0311
added
the
category:port-update
MonicaLiu0311
approved these changes
Mar 3, 2025
MonicaLiu0311
added
the
info:reviewed
dg0yt
suggested changes
Mar 3, 2025
| @@ -20,7 +20,6 @@ vcpkg_cmake_configure( | |||
| -DCMAKE_DISABLE_FIND_PACKAGE_Python3=ON | |||
| -DCMAKE_DISABLE_FIND_PACKAGE_OpenSSL=ON | |||
| -DCMAKE_DISABLE_FIND_PACKAGE_Libngtcp2=ON | |||
| -DCMAKE_DISABLE_FIND_PACKAGE_Libngtcp2_crypto_quictls=ON | |||
There was a problem hiding this comment.
If you remove disabling of dependencies, you probably must add dependencies to the manifest, or you create installation order bugs.
There was a problem hiding this comment.
it is for avoid this warning when build
-- Configuring x64-linux
CMake Warning at installed/x64-linux/share/vcpkg-cmake/vcpkg_cmake_configure.cmake:344 (message):
The following variables are not used in CMakeLists.txt:
CMAKE_DISABLE_FIND_PACKAGE_Libngtcp2_crypto_quictls
Please recheck them and remove the unnecessary options from the
`vcpkg_cmake_configure` call.
If these options should still be passed for whatever reason, please use the
`MAYBE_UNUSED_VARIABLES` argument.
Call Stack (most recent call first):
ports/nghttp2/portfile.cmake:12 (vcpkg_cmake_configure)
scripts/ports.cmake:196 (include)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove cmake with ngtcp2 quictls flags