-
Notifications
You must be signed in to change notification settings - Fork 578
Use main CI workflow for merge queue #790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 81943e0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
Files not reviewed (1)
- .github/workflows/merge-queue.yml: Language not supported
Comments suppressed due to low confidence (4)
.github/workflows/ci.yml:58
- [nitpick] The 'skip' flag is added for Windows and macOS jobs but is not applied to all matrix items (e.g. 'no submodules'). If this behavior is intentional, consider adding a clarifying comment; otherwise, update the matrix to apply 'skip' consistently.
skip: ${{ github.event_name == 'merge_group' }}
.github/workflows/ci.yml:79
- [nitpick] Ensure that 'matrix.values.name' is defined for all matrix items or provide a default so the job naming remains clear and consistent.
name: test (${{ matrix.values.name || matrix.values.os }})
.github/workflows/ci.yml:327
- [nitpick] The dependency 'extension' is newly added in the 'needs' list; confirm that an 'extension' job exists and that its outcomes are appropriately managed in the workflow.
- extension
.github/workflows/ci.yml:341
- The updated jq filter now treats both 'success' and 'skipped' as acceptable outcomes. Double-check that this behavior matches your intent for marking required jobs as passed.
! echo $NEEDS | jq -e 'to_entries[] | { job: .key, result: .value.result } | select((.result == "success" or .result == "skipped") | not)'
I hit the merge button to watch the run in action; race mode in particular takes longer than I'd like, so I'm going to disable that check. https://github.com/microsoft/typescript-go/actions/runs/14451205530/job/40524114981 |
This is a little tricky but I think works.
Basically, just skip all of the macOS jobs (runners are in short supply) and Windows jobs (slow). Running the tests generally speaking is slow enough that we can do basically everything else.