Skip to content

Fix error chaining in getIterationTypesOfIterableSlow #1091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jakebailey
Copy link
Member

Followup to #1059

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes error chaining in getIterationTypesOfIterableSlow by switching to the extended diagnostic method and updates the test baselines to match the new error output.

  • Replaced checkTypeAssignableTo with checkTypeAssignableToEx to include diagnosticOutput
  • Updated iterator and async iterator error baselines to reflect adjusted error counts and messages
  • Removed obsolete .diff baseline files

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
internal/checker/checker.go Uses checkTypeAssignableToEx instead of checkTypeAssignableTo to chain diagnostics
testdata/baselines/reference/submodule/compiler/iteratorExtraParameters.errors.txt.diff Removed outdated diff file
testdata/baselines/reference/submodule/compiler/iteratorExtraParameters.errors.txt Updated error count and message structure
testdata/baselines/reference/submodule/compiler/asyncIteratorExtraParameters.errors.txt.diff Removed outdated diff file
testdata/baselines/reference/submodule/compiler/asyncIteratorExtraParameters.errors.txt Updated error count and message structure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant