Remove failfast in named pipe client #6552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youssef1313
reviewed
Sep 10, 2025
Youssef1313
reviewed
Sep 10, 2025
This reverts commit 12e6fea.
Youssef1313
approved these changes
Sep 11, 2025
Youssef1313
deleted the
dev/mabdullah/use-environment.exit-in-namedpipeclient
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces an RFC document proposing support for running
dotnet testusing the Microsoft Testing Platform, and updates the IPC error handling logic inNamedPipeClient. The RFC outlines a configurable approach that maintains backward compatibility, while the code change ensures more controlled termination in case of IPC failures.SDK Testing Platform RFC:
docs/RFCs/011-Sdk-Testing-Platform.mddescribing a plan to allow users to opt-in to the Microsoft Testing Platform via aglobal.jsonconfiguration, with clear defaults and backward compatibility.Error Handling Improvement:
NamedPipeClient.RequestReplyAsyncto use_environment.Exit(1)for IPC connection loss instead of_environment.FailFast, ensuring the process exits with a specific code for abnormal termination.Fixes #6510