-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: Adding Crew.AI as a plugin. #10474
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python Test Coverage Report •
Python Unit Test Overview
|
python/semantic_kernel/core_plugins/crew_ai/crew_ai_enterprise.py
Outdated
Show resolved
Hide resolved
python/semantic_kernel/core_plugins/crew_ai/crew_ai_enterprise.py
Outdated
Show resolved
Hide resolved
python/semantic_kernel/core_plugins/crew_ai/crew_ai_enterprise.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Eduard van Valkenburg <[email protected]>
Co-authored-by: Eduard van Valkenburg <[email protected]>
Co-authored-by: Eduard van Valkenburg <[email protected]>
Co-authored-by: Eduard van Valkenburg <[email protected]>
Co-authored-by: Eduard van Valkenburg <[email protected]>
TaoChenOSU
reviewed
Feb 11, 2025
python/semantic_kernel/core_plugins/crew_ai/crew_ai_enterprise_client.py
Outdated
Show resolved
Hide resolved
python/semantic_kernel/core_plugins/crew_ai/crew_ai_enterprise_client.py
Outdated
Show resolved
Hide resolved
python/semantic_kernel/core_plugins/crew_ai/crew_ai_settings.py
Outdated
Show resolved
Hide resolved
moonbox3
reviewed
Feb 12, 2025
moonbox3
approved these changes
Feb 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks heaps better, only thing is: get rid of this new InputMetadata and just use KernelParameterMetadata instead, no need for a new concept!
python/semantic_kernel/core_plugins/crew_ai/crew_ai_enterprise.py
Outdated
Show resolved
Hide resolved
python/semantic_kernel/core_plugins/crew_ai/crew_ai_enterprise.py
Outdated
Show resolved
Hide resolved
python/semantic_kernel/core_plugins/crew_ai/crew_ai_enterprise.py
Outdated
Show resolved
Hide resolved
TaoChenOSU
approved these changes
Feb 12, 2025
moonbox3
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Adding Crew.AI as a plugin to the Semantic Kernel will allow users to leverage the capabilities of Crew.AI in app. This plugin works with Crews that have been deployed to the Crew.AI Enterprise service.
Description
Adding Crew.AI as a plugin to the Semantic Kernel will allow users to leverage the capabilities of Crew.AI in app. This plugin works with Crews that have been deployed to the Crew.AI Enterprise service.
The plugin functionality has been manually verified with the concept samples. Other tests will come in the next update.
Contribution Checklist