Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: Adding Crew.AI as a plugin. #10474

Merged
merged 18 commits into from
Feb 13, 2025
Merged

Conversation

alliscode
Copy link
Member

Motivation and Context

Adding Crew.AI as a plugin to the Semantic Kernel will allow users to leverage the capabilities of Crew.AI in app. This plugin works with Crews that have been deployed to the Crew.AI Enterprise service.

Description

Adding Crew.AI as a plugin to the Semantic Kernel will allow users to leverage the capabilities of Crew.AI in app. This plugin works with Crews that have been deployed to the Crew.AI Enterprise service.

The plugin functionality has been manually verified with the concept samples. Other tests will come in the next update.

Contribution Checklist

@alliscode alliscode requested a review from a team as a code owner February 10, 2025 18:42
@markwallace-microsoft markwallace-microsoft added the python Pull requests for the Python Semantic Kernel label Feb 10, 2025
@github-actions github-actions bot changed the title Adding Crew.AI as a plugin. Python: Adding Crew.AI as a plugin. Feb 10, 2025
@markwallace-microsoft
Copy link
Member

markwallace-microsoft commented Feb 10, 2025

Python Test Coverage

Python Test Coverage Report •
FileStmtsMissCoverMissing
semantic_kernel/core_plugins/crew_ai
   crew_ai_enterprise.py871484%70–71, 105–106, 122–123, 160–161, 171, 201–202, 211–218
   crew_ai_enterprise_client.py301550%46–50, 70–81, 92–97, 101–102, 106
TOTAL18751222888% 

Python Unit Test Overview

Tests Skipped Failures Errors Time
3196 5 💤 1 ❌ 0 🔥 1m 44s ⏱️

python/samples/concepts/plugins/crew_ai_plugin.py Outdated Show resolved Hide resolved
python/samples/concepts/plugins/crew_ai_plugin.py Outdated Show resolved Hide resolved
python/samples/concepts/plugins/crew_ai_plugin.py Outdated Show resolved Hide resolved
python/samples/concepts/plugins/crew_ai_plugin.py Outdated Show resolved Hide resolved
python/samples/concepts/plugins/crew_ai_plugin.py Outdated Show resolved Hide resolved
Copy link
Member

@eavanvalkenburg eavanvalkenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks heaps better, only thing is: get rid of this new InputMetadata and just use KernelParameterMetadata instead, no need for a new concept!

@alliscode alliscode enabled auto-merge February 12, 2025 23:07
@alliscode alliscode added this pull request to the merge queue Feb 13, 2025
Merged via the queue into microsoft:main with commit 892c206 Feb 13, 2025
28 checks passed
@alliscode alliscode deleted the crew-ai-py branch February 13, 2025 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation python Pull requests for the Python Semantic Kernel
Projects
Status: Sprint: Done
Development

Successfully merging this pull request may close these issues.

5 participants