Skip to content

fix: allow nightly scan when PR creation is blocked #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mani Bindra (maniSbindra) merged 2 commits into from
Apr 17, 2026
Merged

fix: allow nightly scan when PR creation is blocked #9

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
188b1b2
fix: allow nightly scan when PR creation is blocked
maniSbindra Apr 17, 2026
ae2e1b7
fix: clarify manual PR summary link
maniSbindra Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 48 additions & 4 deletions .github/workflows/nightly-scan.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,23 @@ jobs:
return 1
}

emit_manual_pr_summary() {
local message="$1"
local action_url="${2:-https://github.com/${GITHUB_REPOSITORY}/pull/new/${BRANCH}}"
local action_label="${3:-Open PR manually}"

echo "::warning::${message}"
echo "::warning::${action_label}: ${action_url}"
{
echo "## Nightly scan results pushed"
echo ""
echo "${message}"
echo ""
echo "- Branch: \`${BRANCH}\`"
echo "- ${action_label}: ${action_url}"
} >> "$GITHUB_STEP_SUMMARY"
}

# Validate expected scan artifacts exist
MISSING=()
for f in "${NIGHTLY_ALLOWED_FILES[@]}"; do
Expand Down Expand Up @@ -201,15 +218,42 @@ jobs:
# Create PR if one doesn't already exist (scoped to this repo, not forks)
EXISTING_PR=$(gh pr list --head "${{ github.repository_owner }}:$BRANCH" --base "$DEFAULT_BRANCH" --state open --json number --jq '.[0].number // empty')
if [ -z "$EXISTING_PR" ]; then
gh pr create \
set +e
PR_OUTPUT=$(gh pr create \
--base "$DEFAULT_BRANCH" \
--head "$BRANCH" \
--title "$PR_TITLE" \
--body-file /tmp/nightly-pr-body.md
--body-file /tmp/nightly-pr-body.md 2>&1)
PR_STATUS=$?
set -e

if [ $PR_STATUS -eq 0 ]; then
printf '%s\n' "$PR_OUTPUT"
elif printf '%s' "$PR_OUTPUT" | grep -F -q 'GitHub Actions is not permitted to create or approve pull requests'; then
emit_manual_pr_summary "GitHub Actions could not create a pull request with GITHUB_TOKEN."
else
printf '%s\n' "$PR_OUTPUT" >&2
exit $PR_STATUS
fi
else
gh pr edit "$EXISTING_PR" \
set +e
PR_OUTPUT=$(gh pr edit "$EXISTING_PR" \
--title "$PR_TITLE" \
--body-file /tmp/nightly-pr-body.md
--body-file /tmp/nightly-pr-body.md 2>&1)
PR_STATUS=$?
set -e

if [ $PR_STATUS -eq 0 ]; then
printf '%s\n' "$PR_OUTPUT"
elif printf '%s' "$PR_OUTPUT" | grep -F -q 'GitHub Actions is not permitted to create or approve pull requests'; then
emit_manual_pr_summary \
"GitHub Actions could not update PR #${EXISTING_PR} with GITHUB_TOKEN." \
"https://github.com/${GITHUB_REPOSITORY}/pull/${EXISTING_PR}" \
"Review existing PR manually"
else
Comment thread
maniSbindra marked this conversation as resolved.
printf '%s\n' "$PR_OUTPUT" >&2
exit $PR_STATUS
fi
fi

- name: 📤 Upload database artifact
Expand Down
Loading