fix: treat v-prefixed tags as numeric in digest dedup specificity#82
Open
Abhineshhh wants to merge 1 commit into
Open
fix: treat v-prefixed tags as numeric in digest dedup specificity#82Abhineshhh wants to merge 1 commit into
Abhineshhh wants to merge 1 commit into
Conversation
tagSpecificity only awarded a numeric bonus when the tag started with a digit, so 9.0 outranked v10.0 when choosing a primary digest tag. Skip an optional v/V prefix (when followed by a digit), matching version-aware tag sorting. Fixes microsoft#75
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
tagSpecificity(used by digest dedup) only awarded a numeric bonus when the tag started with a digit, so9.0outrankedv10.0as the primary recommendation. Align with version-aware tag sorting (#68). ## Related Issue Fixes #75 ## Changes - Skip optionalv/Vprefix when followed by a digit before scoring - Regression tests for specificity andDeduplicateByDigest## Checklist - [x]task lintpasses locally - [x]task testpasses locally - [x] Documentation updated (if applicable)Stacking
Independent of the Trivy/registry stacks — can merge in any order relative to them.