fix: sort image tags with version-aware newest-first ordering#68
Open
Abhineshhh wants to merge 1 commit into
Open
fix: sort image tags with version-aware newest-first ordering#68Abhineshhh wants to merge 1 commit into
Abhineshhh wants to merge 1 commit into
Conversation
FilterTags used reverse lexicographic sort, so tags like 9.0 ranked above 10.0. With --max-tags that dropped newer majors from scans. Compare leading numeric version segments so LimitTags keeps the newest releases first.
|
@Abhineshhh please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FilterTagswith version-aware newest-first orderingmajor.minor.patch…) are compared so10.0ranks above9.0--max-tags/LimitTagskeeps the newest releases instead of dropping themFixes #66
Test plan
go test ./pkg/infrastructure/scanner/ -count=1TestFilterTags_VersionAwareNewestFirst,TestSortTagsNewestFirst,TestVersionPrefixTestFilterTags/TestLimitTagsstill pass