fix: generate detailed JSON report in nightly scan - #46
Merged
Conversation
Add the detailed report flag to the nightly scan and allow the generated detail JSON artifact through the nightly output validation. Fixes #45 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Mani Bindra (maniSbindra)
requested a review
from Dariusz Porowski (DariuszPorowski)
as a code owner
May 27, 2026 16:05
There was a problem hiding this comment.
Pull request overview
This PR updates the nightly scan automation to produce the detailed per-image JSON report and allow it as an expected nightly output artifact.
Changes:
- Adds
--detailedto the nightlysbi scaninvocation. - Adds
docs/daily_recommendations_detail.jsonto the nightly output allowlist.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/nightly-scan.yml |
Enables detailed JSON report generation during the nightly scan. |
.github/nightly-allowed-files.sh |
Adds the detailed JSON report to the files accepted by nightly commit validation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the
--detailedflag to the nightly scan workflow sodocs/daily_recommendations_detail.jsonis generated alongside the existing markdown and JSON reports.Changes
.github/workflows/nightly-scan.yml— add--detailedto thesbi scaninvocation.github/nightly-allowed-files.sh— adddocs/daily_recommendations_detail.jsonto the nightly output allowlist so the commit validation accepts the new artifactContext
The CLI already supports
--detailedand locally produces the report correctly. The nightly workflow simply wasn't passing the flag, and the allowlist would have rejected the file as unexpected output.Fixes #45