Skip to content

docs: fix README CLI flags table - #11

Merged
Mani Bindra (maniSbindra) merged 2 commits into
mainfrom
docs/fix-readme-cli-flags
Apr 17, 2026
Merged

docs: fix README CLI flags table#11
Mani Bindra (maniSbindra) merged 2 commits into
mainfrom
docs/fix-readme-cli-flags

Conversation

@maniSbindra

Copy link
Copy Markdown
Member

Summary

Fixes the CLI flags table in README.md which was outdated and incomplete.

Changes

  • Separate global vs scan-specific flags — flags like --top-n, --verbose, --database are global (available on all subcommands), not scan-only
  • Add missing flags: --json-top-n, --debug/-d, --no-cleanup
  • Fix --top-n description: ranked per language per base OS, not just per language
  • Correct descriptions to match actual --help output

- Separate global flags from scan-specific flags
- Add missing flags: --json-top-n, --debug/-d, --no-cleanup
- Fix --top-n description: 'per language per base OS' (not just 'per language')
- Correct flag scoping (--top-n, --verbose etc. are global, not scan-only)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the README’s CLI flags documentation so it reflects the current Cobra --help output and correctly distinguishes between persistent (global) flags and scan-specific flags.

Changes:

  • Split the CLI flags table into Global vs scan sections.
  • Added missing documented flags: --json-top-n, --debug/-d, --no-cleanup.
  • Corrected/clarified flag descriptions (notably --top-n semantics).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread README.md Outdated
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@maniSbindra

Copy link
Copy Markdown
Member Author

Copilot please review

Copilot AI commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

Copilot please review

The PR looks good. All flag descriptions in the README match the actual CLI --help output (verified against rootCmd.go and scanCmd.go). The previously flagged --update-existing description was already aligned to "Rescan existing images" in commit ece3da0.

@maniSbindra
Mani Bindra (maniSbindra) merged commit 773140a into main Apr 17, 2026
15 checks passed
@maniSbindra
Mani Bindra (maniSbindra) deleted the docs/fix-readme-cli-flags branch April 17, 2026 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants