Skip to content

fix(msal): update syntax for iOS 17+ #4193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tido64 merged 1 commit into from
Jun 9, 2026
+13 −6
Merged

fix(msal): update syntax for iOS 17+ #4193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/six-crabs-poke.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@rnx-kit/react-native-test-app-msal": minor
---

- Bumped iOS deployment target to 15.1
- Bumped macOS deployment targt to 14.0
- Minor updates to satisfy deprecations in iOS 17+
4 changes: 2 additions & 2 deletions incubator/react-native-test-app-msal/ReactTestApp-MSAL.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ Pod::Spec.new do |s|
s.source = { :git => package['repository']['url'], :tag => "#{package['name']}@#{version}" }
s.summary = package['description']

s.ios.deployment_target = '14.0'
s.osx.deployment_target = '11.0'
s.ios.deployment_target = '15.1'
s.osx.deployment_target = '14.0'

s.dependency 'MSAL'

Expand Down
2 changes: 1 addition & 1 deletion incubator/react-native-test-app-msal/ios/AccountsView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,9 @@
}
.truncationMode(.middle)
}
.onChange(of: selectedAccount) {

Check failure on line 49 in incubator/react-native-test-app-msal/ios/AccountsView.swift

View workflow job for this annotation

GitHub Actions / Build iOS 

'onChange(of:initial:_:)' is only available in iOS 17.0 or newer
// `didSet` is not called when selection is changed
onAccountSelected($0)
onAccountSelected(selectedAccount)
}
.disabled(accounts.isEmpty)
#if os(iOS)
Expand Down
6 changes: 3 additions & 3 deletions packages/test-app-macos/macos/Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2257,7 +2257,7 @@ PODS:
- React-perflogger (= 0.81.5)
- React-utils (= 0.81.5)
- SocketRocket
- ReactNativeHost (0.5.16):
- ReactNativeHost (0.5.19):
- boost
- DoubleConversion
- fast_float
Expand Down Expand Up @@ -2641,9 +2641,9 @@ SPEC CHECKSUMS:
ReactAppDependencyProvider: dddd83e92ff2e76331e033a983785f1f242e0485
ReactCodegen: c693c2c638d755e5f8d83663423b2d81d5aeb66e
ReactCommon: 2024e8fc1841d1e289c5bc5b26aaf0e6ced45142
ReactNativeHost: ba9bdd449af5c793d28ff2610c1bec3015d014cc
ReactNativeHost: 8680b5bbc3afdbfeccc206ed0f3230d7c3df691b
ReactTestApp-DevSupport: d9358fe3b2dc09399c15731ed8c17bd8388cf512
ReactTestApp-MSAL: 778502496ada0c04f0a96cbcc8359d681c458ace
ReactTestApp-MSAL: 26b6509133a8c169934594d8cd20adb4aadb03ee
ReactTestApp-Resources: 73ed16e66e4d7bcb2d98d5c81619e2bc7563d37d
RNWWebStorage: 8ec03f8288c1e212518f662f44ec223603bbe74c
RNXAuth: a54c1a2349766f9d0876d23d90a206a73ddd7d87
Expand Down
Loading