Skip to content

chore: reformat Hermes version string to fix layout issues #2550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tido64 merged 1 commit into from
Aug 27, 2025
Merged

chore: reformat Hermes version string to fix layout issues #2550

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 17 additions & 9 deletions example/src/core.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,15 @@ export type ReactNativeVersion = {
export const ReactNativeVersion: ReactNativeVersion = (() => {
// https://github.com/facebook/react-native/commit/ec5638abd0e872be62b6ea5d8df9bed6335c2191
const { ReactNativeVersion } = require("react-native");
if (ReactNativeVersion) {
return ReactNativeVersion;
}

const { version } = require("react-native/Libraries/Core/ReactNativeVersion");
const { major, minor, patch, prerelease } =
ReactNativeVersion ??
require("react-native/Libraries/Core/ReactNativeVersion").version;
return {
...version,
major,
minor,
patch,
prerelease,
getVersionString: () => {
const { major, minor, patch, prerelease } = version;
const v = `${major}.${minor}.${patch}`;
return prerelease ? `${v}-${prerelease.replace("-", "\n")}` : v;
},
Expand All @@ -38,11 +38,19 @@ export function getHermesVersion(): string | undefined {
return undefined;
}

return `Hermes ${version}`;
const [core, prerelease, ...build] = version.split("-");
const parts = [core];
if (prerelease) {
parts.push("-", prerelease);
if (build.length > 0) {
parts.push("\n", build.join("-"));
}
}
return `Hermes ${parts.join("")}`;
}

export function isBridgeless() {
return "RN$Bridgeless" in global && RN$Bridgeless === true;
return "RN$Bridgeless" in global && global.RN$Bridgeless === true;
}

export function isConcurrentReactEnabled(
Expand Down