Add observable dynamic mode decomposition#392
Draft
v-boqinzhang wants to merge 38 commits intomainfrom
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an Observable Dynamic Mode Decomposition (ODMD) phase-estimation implementation that measures overlap observables via Hadamard tests and classically extracts an energy estimate by building/diagonalizing a DMD system matrix.
Changes:
- Introduces
DynamicModeDecompositionand settings, including Hankel matrix construction + iterative rank growth. - Adds circuit construction and measurement routines (real/imag Hadamard tests) to gather ODMD observables.
- Produces a
QpeResultfrom the estimated phase fraction.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
python/src/qdk_chemistry/algorithms/phase_estimation/dynamic_mode_decomposition.py
Outdated
Show resolved
Hide resolved
python/src/qdk_chemistry/algorithms/phase_estimation/dynamic_mode_decomposition.py
Outdated
Show resolved
Hide resolved
python/src/qdk_chemistry/algorithms/phase_estimation/dynamic_mode_decomposition.py
Outdated
Show resolved
Hide resolved
python/src/qdk_chemistry/algorithms/phase_estimation/dynamic_mode_decomposition.py
Outdated
Show resolved
Hide resolved
python/src/qdk_chemistry/algorithms/phase_estimation/dynamic_mode_decomposition.py
Outdated
Show resolved
Hide resolved
python/src/qdk_chemistry/algorithms/phase_estimation/dynamic_mode_decomposition.py
Outdated
Show resolved
Hide resolved
python/src/qdk_chemistry/algorithms/phase_estimation/dynamic_mode_decomposition.py
Outdated
Show resolved
Hide resolved
python/src/qdk_chemistry/algorithms/phase_estimation/dynamic_mode_decomposition.py
Outdated
Show resolved
Hide resolved
python/src/qdk_chemistry/algorithms/phase_estimation/dynamic_mode_decomposition.py
Outdated
Show resolved
Hide resolved
📊 Coverage Summary
Detailed Coverage ReportsC++ Coverage DetailsPython Coverage DetailsPybind11 Coverage Details |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
python/src/qdk_chemistry/algorithms/phase_estimation/measure_observable.py
Outdated
Show resolved
Hide resolved
python/src/qdk_chemistry/utils/qsharp/DynamicModeDecomposition.qs
Outdated
Show resolved
Hide resolved
python/src/qdk_chemistry/algorithms/phase_estimation/dynamic_mode_decomposition.py
Outdated
Show resolved
Hide resolved
python/src/qdk_chemistry/algorithms/phase_estimation/dynamic_mode_decomposition.py
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.