Skip to content

Add TargetEncoder for scikit-learn #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 23, 2025
Merged

Add TargetEncoder for scikit-learn #384

merged 7 commits into from
Jun 23, 2025

Conversation

x99b
Copy link
Contributor

@x99b x99b commented Jun 12, 2025 •
edited
Loading

Avasam
Avasam approved these changes Jun 20, 2025
View reviewed changes
Copy link
Contributor

@Avasam Avasam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't runtime validated the ndarray. But I too a glance at the implementation and this LGTM.

@Avasam
Copy link
Contributor

Avasam commented Jun 20, 2025

note: unused allowlist entry sklearn.preprocessing.TargetEncoder
note: unused allowlist entry sklearn.preprocessing.all

If you remove those 2 lines from the stubtest_allowlist.txt file, it'll be good to go!

@debonte
Copy link
Contributor

debonte commented Jun 23, 2025

Thanks for the contribution @x99b!

@debonte debonte merged commit d1b4fb3 into microsoft:main Jun 23, 2025
8 checks passed
@Avasam Avasam mentioned this pull request Jun 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Avasam Avasam Avasam approved these changes

@debonte debonte debonte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@x99b @Avasam @debonte