Skip to content
This repository was archived by the owner on Sep 3, 2026. It is now read-only.
This repository was archived by the owner on Sep 3, 2026. It is now read-only.

Motif guidance scale factors seem to be missing #31

Description

In

var_rot = rt_sq_rot[:, None, None]

the value of rt_sq_rot during inference is always None. Also, it doesn't seem like rt_sq_rot is defined anywhere else in the code. Am I simply missing something in the codebase that defines this value?

Referencing the repo's TMLR paper, do you simply define it as follows?

rt_sq_rot = ((1 - batch['so3_t']) ** 2) / (batch['so3_t'] ** 2 + (1 - batch['so3_t']) ** 2)

If so, how does the extra / 2 term fit into the following calculation?

log_p_rot = -((R_obs - R_pred)**2 / 2 / var_rot).sum(dim=[-3, -2, -1])

Perhaps this is based on the following definition of Gaussian negative log likelihood (reference: https://stats.stackexchange.com/questions/521091/optimizing-gaussian-negative-log-likelihood)?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions