chore: ensure ffmpeg is installed when saving video #37997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yury-s
approved these changes
Oct 24, 2025
| const config = await resolveCLIConfig(options); | ||
|
|
||
| // Chromium browsers require ffmpeg to be installed to save video. | ||
| if (config.saveVideo) |
There was a problem hiding this comment.
Let the users do it manually or at least print a message to stderr that we are dowloading something?
This comment has been minimized.
This comment has been minimized.
pavelfeldman
force-pushed
the
install_video
branch
from
200ac37 to
3b96851
Compare
yury-s
approved these changes
Oct 24, 2025
| console.error(colors.red(`\nError: ffmpeg required to save the video is not installed.`)); | ||
| console.error(`\nPlease run the command below. It will install a local copy of ffmpeg and will not change any system-wide settings.`); | ||
| console.error(`\n npx playwright install ffmpeg\n`); | ||
| // eslint-disable-next-line no-restricted-properties |
There was a problem hiding this comment.
Add a note about the directory where to run the command?
Test results for "MCP"2 failed 2568 passed, 108 skipped Merge workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/playwright-mcp#1134