fix(trace-viewer): decode + quote report path in fallback “Copy Command” (file://) #37710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@microsoft-github-policy-service agree |
This comment has been minimized.
This comment has been minimized.
…th platform-specific command
nilgaar
force-pushed
the
fix/37709-trace-viewer-quote-decode
branch
from
3edd962 to
8eb851e
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…oving platform-specific path handling
This comment has been minimized.
This comment has been minimized.
Skn0tt
reviewed
Oct 6, 2025
Member
Skn0tt
left a comment
Skn0tt
left a comment
There was a problem hiding this comment.
Hi! Thanks for taking the time to open a PR. From a cursory look, this seems like it's going in the right direction. Could you make sure that there's no formatting changes mixed in? That'd make it a lot easier to review + accept.
This comment has been minimized.
This comment has been minimized.
…ith proper path handling
nilgaar
force-pushed
the
fix/37709-trace-viewer-quote-decode
branch
from
9c802b5 to
8f3f1c8
Compare
Contributor
Test results for "tests 1"2 flaky46926 passed, 816 skipped Merge workflow run. |
dgozman
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37709.
Updates the Trace Viewer fallback dialog (when opened via
file://) to produce a working “Copy Command.”It now decodes the URL path and quotes it (and normalizes slashes on Windows), so paths with spaces or special characters open correctly via
npx playwright show-report.