Skip to content

Conversation

stefanseeger
Copy link

For me reading the doc was a bit confusing.

  1. The / character implies a "or" to me not an and (but I'm no native speaker)
  2. Not highlighting the property names made it harder to read
  3. There was a missing "." in the path description

@stefanseeger stefanseeger changed the title docs: Enhance api/class-browsercontext.md docs: Enhance docs/src/api/class-browsercontext.md Oct 2, 2025
Copy link
Contributor

@dgozman dgozman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! Unfortunately, it's not enough to just change this file. You need to run npm run build or npm run watch. See contributing guide for more details. Thank you!

Comment on lines +330 to +332
- `url` ?<[string]> Either `url` or `domain` and `path` are required. Optional.
- `domain` ?<[string]> For the cookie to apply to all subdomains as well, prefix domain with a dot, like this: ".example.com". Either `url` or `domain` and `path` are required. Optional.
- `path` ?<[string]> Either `url` or `domain` and `path` are required. Optional.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make it 100% clear:

Suggested change
- `url` ?<[string]> Either `url` or `domain` and `path` are required. Optional.
- `domain` ?<[string]> For the cookie to apply to all subdomains as well, prefix domain with a dot, like this: ".example.com". Either `url` or `domain` and `path` are required. Optional.
- `path` ?<[string]> Either `url` or `domain` and `path` are required. Optional.
- `url` ?<[string]> Either `url` or both `domain` and `path` are required. Optional.
- `domain` ?<[string]> For the cookie to apply to all subdomains as well, prefix domain with a dot, like this: ".example.com". Either `url` or both `domain` and `path` are required. Optional.
- `path` ?<[string]> Either `url` or both `domain` and `path` are required. Optional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants