fix(ui-mode): prevent OOM crash when DEBUG logging enabled #35827
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When UI mode is launched with enough
debug
logging enabled (such asDEBUG=*
), Playwright would end up crashing with an OOM error after a few seconds. This has been reported several times recently (#35706, #33086, #35152, and likely more).This change prevents any
debug
logging generated in the runner process from being redirected for further processing (such as sending to the UI). This does not block alldebug
logging from getting to the UI; logs created in workers and possibly other processes are no longer "labeled" once reaching this redirection code, and thus are still sent along. This appears to be sufficient to solve the crash. These untoucheddebug
logs appear in the global UI mode console.