Skip to content

fix(registry): create unique browser download path #35673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

gotlougit
Copy link

This allows concurrent downloads of browsers by
Playwright.

Fixes #32179

@gotlougit gotlougit force-pushed the unique-download-path branch from 6b17776 to b279325 Compare April 19, 2025 12:27

This comment has been minimized.

This comment has been minimized.

@gotlougit gotlougit force-pushed the unique-download-path branch 2 times, most recently from 8d3feaa to 8225573 Compare April 22, 2025 13:30

This comment has been minimized.

This comment has been minimized.

This allows concurrent downloads of browsers by
Playwright.

Fixes microsoft#32179
@gotlougit gotlougit force-pushed the unique-download-path branch from 8225573 to 2f31811 Compare May 1, 2025 06:12
Copy link
Contributor

github-actions bot commented May 1, 2025

Test results for "tests 1"

2 failed
❌ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
❌ [webkit-library] › library/browsercontext-pages.spec.ts:105:3 › should return bounding box with page scale @webkit-ubuntu-22.04-node18

4 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18
⚠️ [webkit-library] › library/ignorehttpserrors.spec.ts:30:3 › should isolate contexts @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/screenshot.spec.ts:205:14 › element screenshot › element screenshot should work with a mobile viewport @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

39118 passed, 803 skipped
✔️✔️✔️

Merge workflow run.

@dgozman
Copy link
Contributor

dgozman commented May 1, 2025

@gotlougit The linter is unhappy, and for a reason. You can run it locally with npm run lint.

@Skn0tt
Copy link
Member

Skn0tt commented May 15, 2025

closing as stale. feel free to reopen as a separate PR.

@Skn0tt Skn0tt closed this May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Jobs running concurrently on the same machine download browsers to the same directory and clobber each other (Windows)
4 participants