Skip to content

Conversation

vincentsarago
Copy link
Contributor

@vincentsarago vincentsarago commented May 15, 2025

This PR does:

  • update pctiler to require python>=3.9
  • update titiler, titiler-pgstac, rasterio versions

TODO

  • Questions
  • Update CI

return result


# /tiles endpoint compat with titiler<0.15, Optional `tileMatrixSetId`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added this because I thought we needed default WebMercatorQuad tilematrixset back.

We can remove if not needed

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep it, I see in our logs that we do have callers that request tiles without a TMS in the path.

For others, you can verify with this query in pc-api-appinsights:

ProductionRequests
| where name == "GET" and service == "tiler"
| where not(url  has "/preview.png")
| where url has "item/tiles" and not(url has "tiles/WebMercatorQuad")

def tile_routes( # type: ignore
request: Request,
search_id=Depends(pgstac_mosaic_factory.path_dependency),
tile=Depends(TmsTileParams),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TmsTileParams is not used anymore in titiler-pgstac so it might disappear 🙈

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a problem!

@ghidalgo3
Copy link
Collaborator

The CI/CD pipeline for this repo is functional. Once you pass the pipeline and merge this into main, it will be deployed and available at planetarycomputer-test.microsoft.com. Let's merge this and test that the test environment is working.

@vincentsarago vincentsarago marked this pull request as ready for review June 2, 2025 07:46
@vincentsarago vincentsarago requested a review from ghidalgo3 June 2, 2025 07:46
@ghidalgo3
Copy link
Collaborator

I have edited the settings to allow your commits to run CI/CD automatically.

@vincentsarago vincentsarago force-pushed the feature/update-titiler-version branch from 7eab044 to f6ee228 Compare June 17, 2025 20:38
@vincentsarago
Copy link
Contributor Author

@ghidalgo3 could you help me debug the azurite error message 🙏

Copy link

@hrodmn hrodmn Jun 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vincentsarago do you know why all of these requirement versions got bumped? I created a branch off of your branch to work on telemetry and when I ran ./scripts/generate-requirements the pinned versions all got bumped back to match the main branch 🤔

developmentseed#3

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually delete the previous files and re-generate from scratch (I think I had issues before trying to update the files in place)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants