Skip to content

Include datas in GCSettingsEvent #2157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Include datas in GCSettingsEvent #2157

wants to merge 1 commit into from

Conversation

cshung
Copy link
Contributor

@cshung cshung commented Jan 31, 2025 •
edited
Loading

This allow us to know if DATAS is enabled through the trace when the GCSettingsRundown event is enabled.

Runtime support is here

Update: The runtime-side is likely going to stall for a long while, this change can wait.

@cshung cshung requested a review from brianrob as a code owner January 31, 2025 00:03
@cshung cshung mentioned this pull request Jan 31, 2025
Open
@cincuranet
Copy link
Collaborator

@cshung LGTM. Let me know when you want to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cincuranet cincuranet cincuranet approved these changes

@brianrob brianrob Awaiting requested review from brianrob brianrob is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cshung @cincuranet