-
Notifications
You must be signed in to change notification settings - Fork 148
uh_mem: Fix a few oversights and edge cases #2009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes several security and correctness issues in the underhill_mem memory protection subsystem, addressing edge cases around SNP memory unacceptance, overlay page permissions, and locked page handling.
- Adds permission revocation before unaccepting pages on SNP to close a security window
- Prevents permission changes on individual overlay pages to avoid race conditions
- Refactors locked page checking logic to be more robust
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
File | Description |
---|---|
openhcl/underhill_mem/src/lib.rs | Main fixes for SNP unacceptance, overlay page validation, and locked page handling logic |
openhcl/underhill_mem/src/init.rs | Removes outdated comment about HCL Arc usage |
c59eda6
to
5901c0e
Compare
This fixes some oversights and edge cases in underhill_mem that were pointed out during an audit of our memory protections code.
Fixes #1021