Skip to content

Document 0.7 contract annotations - #907

Merged
Gudge (MGudgin) merged 1 commit into
mainfrom
user/gudge/version_specific_config_parsers_phase4_1
Aug 14, 2026
Merged

Document 0.7 contract annotations#907
Gudge (MGudgin) merged 1 commit into
mainfrom
user/gudge/version_specific_config_parsers_phase4_1

Conversation

@MGudgin

@MGudgin Gudge (MGudgin) commented Aug 14, 2026

Copy link
Copy Markdown
Member

Document 0.7 contract annotations

This PR documents the annotation fields exposed by the published 0.7.0-alpha configuration contract.

Details

  • Document the optional $schema editor-validation reference.
  • Document the ignored _comment annotation value.
  • Make the contract crate pass a strict missing_docs rustdoc build.

Tests

  • cargo fmt --all -- --check
  • $env:RUSTDOCFLAGS='-D missing-docs'; cargo doc -p mxc_config_contract --no-deps
  • cargo test -p mxc_config_contract (175 tests passed)
  • cargo clippy -p mxc_config_contract --all-targets -- -D warnings
  • git diff --check
Microsoft Reviewers: Open in CodeFlow

This PR documents the annotation fields exposed by the published 0.7 configuration contract.

Details

* Document the optional `$schema` editor-validation reference.
* Document the ignored `_comment` annotation value.

Tests

* `cargo fmt --all -- --check`
* `$env:RUSTDOCFLAGS='-D missing-docs'; cargo doc -p mxc_config_contract --no-deps`
* `cargo test -p mxc_config_contract` (175 tests passed)
* `cargo clippy -p mxc_config_contract --all-targets -- -D warnings`

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@MGudgin
Gudge (MGudgin) requested a review from a team as a code owner August 14, 2026 19:42
Copilot AI balanced review requested due to automatic review settings August 14, 2026 19:42
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@MGudgin Gudge (MGudgin) changed the title Document 0.7 contract annotations (Phase 4.1) Document 0.7 contract annotations Aug 14, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Documents the published 0.7.0-alpha contract annotations for strict rustdoc validation.

Changes:

  • Documents $schema editor validation.
  • Documents ignored _comment annotations.
Show a summary per file
File Description
src/core/mxc_config_contract/src/published/v0_7_0_alpha/request.rs Adds rustdoc for annotation fields.

Review details

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Balanced

@MGudgin
Gudge (MGudgin) merged commit 2bbd034 into main Aug 14, 2026
44 checks passed
@MGudgin
Gudge (MGudgin) deleted the user/gudge/version_specific_config_parsers_phase4_1 branch August 14, 2026 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants